Conversation
maxn990
left a comment
maxn990
left a comment
There was a problem hiding this comment.
Nice! I think you may have added slightly more padding/spacing than is on the figma, but otherwise looks really good. I just had a quick question too that I added in comments, but otherwise it looks really good!!
There was a problem hiding this comment.
is there a reason this alert is in a portal and none of the others are?
There was a problem hiding this comment.
Hey max! To be honest no reason, I moved it out
There was a problem hiding this comment.
Was just popping my head in here while looking at something else (don't block the merge on my approval) but I know the volunteer management page already uses the Chakra alert component directly - should we be updating that usage too to use your new component?
Yup that makes sense, made those changes! |
4 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-124
📝 Description
This PR simply replaced native browser alerts with chakra alerts for better visuals. It only changes alerts that are on pages with updated designs according to the figma so some native alert() usages still exist but those will be updated when those pages get visually updated.
To make this change, I added a new reusable floatingAlert component
The routes effected are:
/admin-donation, /admin-order-management, /request-form/:pantryId
✔️ Verification
I verified each alert showed up as applicable.
🏕️ (Optional) Future Work / Notes